[Feature] support prompt repetition_penalty #2806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
…into repetition_penalty
…into repetition_penalty
ming1753
changed the title
carryyu
reviewed
Jul 15, 2025
| } | ||
| } | ||
| if (i < prompt_len_now) { | ||
| int64_t id = prompt_ids[i]; |
| int times = repeat_times_now[i]; | ||
| float logit_now = static_cast<float>(logits_now[i]); | ||
| if (times != 0) { | ||
| if (is_repeated[i] != 0) { |
carryyu
reviewed
Jul 15, 2025
| if (i < prompt_len_now) { | ||
| int64_t id = prompt_ids[i]; | ||
| if (id >= 0) { | ||
| atomicAdd(&is_repeated_now[id], 1); |
There was a problem hiding this comment.
出现在prompt的token不用记入repeat_times吗，这块逻辑是否与模型组确认
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Prompt Repetition Penalty